(#h75wtqq) @xuu@txt.sour.is My layout looks like this:

• storage/
  
  • storage.go: defines a Storage interface
    
  • sqlite.go: implements the Storage interface
    
  • sqlite_test.go: originally had a function to set up a test storage to test the SQLite storage implementation itself: newRAMStorage(testing.T, $initialData) *Storage
    
• controller/
  
  • feeds.go: uses a Storage
    
  • feeds_test.go: here I wanted to reuse the newRAMStorage(…) function
    

I then tried to relocate the newRAMStorage(…) into a

• teststorage/
  
  • storage.go: moved here as NewRAMStorage(…)
    

so that I could just reuse it from both

• storage/
  
  • sqlite_test.go: uses testutils.NewRAMStorage(…)
    
• controller/
  
  • feeds_test.go: uses testutils.NewRamStorage(…)
    

But that results into an import cycle, because the teststorage package imports storage for storage.Storage and the storage package imports testutils for testutils.NewRAMStorage(…) in its test. I’m just screwed. For now, I duplicated it as newRAMStorage(…) in controller/feeds_test.go.

I could put NewRAMStorage(…) in storage/testutils.go, which could be guarded with //go:build testutils. With go test -tags testutils …, in storage/sqlite_test.go could just use NewRAMStorage(…) directly and similarly in controller/feeds_test.go I could call storage.NewRamStorage(…). But I don’t know if I would consider this really elegant.

The more I think about it, the more appealing it sounds. Because I could then also use other test-related stuff across packages without introducing other dedicated test packages. Build some assertions, converters, types etc. directly into the same package, maybe even make them methods of types.

If I went that route, I might do the opposite with the build tag and make it something like !prod instead of testing. Only when building the final binary, I would have to specify the tag to exclude all the non-prod stuff. Hmmm.